Improve joint calibration controller #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to publish messages with 2Hz to say calibration completed.
For smooth slow motions through the zero crossing it can be helpful to increase the distance before passing through it from low to high. As a longer default time changes the well-established startup initialization to the worse (more collisions) it's better to turn it into a parameter without changing the default.
v4hn
force-pushed
the
improve_joint_calibration_controller
branch
from
a1a4789 to
8cf343c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the calibration controllers more flexible without changing behavior in an inappropriate way.
The only change in existing functionality is that the
calibratedtopic will only be published once as a latch message instead of continuously announcing over and over again to the same clients that it finished calibrating.This works together with https://github.com/TAMS-Group/tams_pr2_refine_startup_calibration to provide a more accurate initialization to detect the hardware zero crossings. In practice we can reduce the noise (one sample per startup) of detection from up to 0.2rad(!) to around 0.01-0.02 depending on the joint.
I am utterly confused why nobody looked into this before and although our transmission belts might be especially loose the procedure can definitely also improve precision of other group's robots.
@k-okada I use this on our PR2. Are you ok with me merging this here?